Don't reset unread count when adding a synthetic receipt #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3684 and there are lots more details about why we chose this solution in that issue.
weeman1337
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Looks good to me. 👍 I don't know all of the read receipt details. But implementation matches the comment from here.
|
I would say we are not 100% confident on this change, which is why we are merging soon after the RC was cut. All the tests that we have are passing, but we don't feel they cover all the cases yet. When element-hq/element-web#25449 is done, we should be more confident. |
andybalaam
deleted the
andybalaam/dont-reset-unread-on-synthetic-receipt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3684 and there are lots more details about why we chose this solution in that issue.
Here's what your changelog entry will look like:
🐛 Bug Fixes